This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[v1.x][Bugfix] Fix take gradient #20166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @waytrue17 , Thanks for submitting the PR
CI supported jobs: [sanity, centos-gpu, centos-cpu, edge, miscellaneous, windows-gpu, unix-gpu, unix-cpu, clang, windows-cpu, website] Note: |
lanking520
added
pr-awaiting-testing
|
Thanks @waytrue17. Could you add a test for the bug? Is this patch needed for master? |
Test added. Master also needs this. I can port it after this pr merged |
|
@mxnet-bot run ci [centos-cpu] |
|
@waytrue17 thanks for the fix |
This was referenced Apr 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #19817. Reset value of
grad_inwhenaxis != 0. The fix was tested by the script described in #19817Checklist
Essentials
Changes
Comments